Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if setSelectedCandidatePair() is called early? #180

Closed
jan-ivar opened this issue Oct 30, 2023 · 1 comment · Fixed by #181
Closed

What happens if setSelectedCandidatePair() is called early? #180

jan-ivar opened this issue Oct 30, 2023 · 1 comment · Fixed by #181
Assignees

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Oct 30, 2023

In § 9. RTCIceTransport extensions between two "When the ICE agent [does X]" sections, it says:

We should reserve "may" and "MAY" for implementations and avoid using it to describe requirements on applications.

The intent of this statement is also unclear, since an application can call a method at any time. If we meant for this method to throw or reject if called outside this condition, that needs to go into its algorithm.

Also, the change the selected candidate pair algorithm itself has some bugs, like inferring transport from the passed-in candidatePair.

I think it's better to move this algorithm to the method itself.

Assuming there is no limit on when this method can be called, I'll do a PR to that effect.

@henbos
Copy link
Collaborator

henbos commented Oct 31, 2023

CC @sam-vi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants