Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Use consistent syntax for enum values and strings #1370

Closed
adam-be opened this issue Jun 9, 2017 · 3 comments
Closed

Editorial: Use consistent syntax for enum values and strings #1370

adam-be opened this issue Jun 9, 2017 · 3 comments
Assignees

Comments

@adam-be
Copy link
Member

adam-be commented Jun 9, 2017

Now we just have to decide on an approach. :)

@jan-ivar
Copy link
Member

jan-ivar commented Jun 9, 2017

FWIW WebIDL enumeration values are strings. Both in all observable JS ways, and in WebIDL definitions. e.g. http://w3c.github.io/webrtc-pc/#rtcpeerconnectionstate-enum

@jan-ivar
Copy link
Member

jan-ivar commented Jun 9, 2017

In binding code it varies I think. In c++ implementation's they're c++ enum. In JS-implemented code they're strings. At least in our case.

@burnburn
Copy link
Contributor

With #1485 I think this is done.

@aboba aboba closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants