-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limiting number of RTCRtpTransceivers #1507
Comments
I think this is a more generic question. In 'Is there a limit on the number of RTCRtpTransceivers an application can create?' you could replace 'RTCRtpTransceivers' with e.g. RTCPeerConnections, or WebSockets, or MediaStreams, etc. and I assume there is a limit (depending on browser, system, HW etc.), but AFAIK no way to determine what the limit is. |
@stefhak yeah, my first question is fairly generic/obvious. I too assume there is a limit. I'm actually interested in the follow-on questions. Although JSEP specifies that we can reuse a stopped RTCRtpTransceiver's m= section, there isn't a similar behavior at the WebRTC layer for "freeing" stopped RTCRtpTransceivers. AFAICT, if I have some long-lived application calling Can this or should this be changed? E.g., by removing stopped RTCRtpTransceivers from the RTCPeerConnection's set of transceivers? By reusing RTCRtpSenders in more scenarios? |
@markandrus got that! |
What about stats that need to remain for these objects? |
I think it would be reasonable to say that when a transceiver is stopped, and its m= section is recycled for another transceiver (meaning it's "not associated" with an m= section any more), it gets removed from the set of transceivers, since it's not needed by JSEP's algorithms any more. But Dan's point about stats is that we already have another problem about memory use increasing indefinitely. Stats for deleted objects are kept around forever:
|
@stefhak Is this issue really for WebRTC-PC or for WebRTC-Stats? |
@aboba I think it is an Issue for webrtc-stats, I've opened w3c/webrtc-stats#235 and am closing this Issue. |
Hi, Thanks for the discussion everyone. Good point on the stats, I had not considered it. However, should we close this issue so soon? I was interested in what @taylor-b mentioned:
Is there any interest on this from implementors? Can we continue tracking this either here or in another issue? Speaking as a library author, I am still a little concerned with the potential for many RTCRtpTransceivers (although I had totally missed the stats issue). Thanks, |
Hi,
I have a few questions. As far as I can tell,
addTransceiver
andstop
over the course of a few rounds of negotiation, JSEP says we can recycle m= sections. This is nice because we don't necessarily need to keep adding m= sections to our SDP. (Example 1)addTrack
andremoveTrack
exclusively (noreplaceTrack
), the number of RTCRtpTransceivers will grow with each call toaddTrack
. We can only reuse a sender that "has never been used to send." (Example 2)If my understanding is correct, then I would like to know,
Thanks,
Mark
The text was updated successfully, but these errors were encountered: