Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDataChannel.send steps for bufferedAmount #1824

Closed
lgrahl opened this issue Apr 2, 2018 · 1 comment
Closed

RTCDataChannel.send steps for bufferedAmount #1824

lgrahl opened this issue Apr 2, 2018 · 1 comment
Assignees

Comments

@lgrahl
Copy link
Contributor

lgrahl commented Apr 2, 2018

Step 3 states:

Let data be a byte buffer that represents the result of encoding the method's argument as UTF-8 and increase the value of the [[BufferedAmount]] slot with the length of data.

But step 4 raises TypeError in case the message is too large to be sent (> maxMessageSize). So, [[BufferedAmount]] should not be increased before that.


Two more things:

  • Step 4 should explicitly mention that size of data means the size in bytes.
  • A typo in two places: slot with the the length.
@lgrahl lgrahl changed the title RTCDataChannel.send steps RTCDataChannel.send steps for bufferedAmount Apr 11, 2018
@stefhak
Copy link
Contributor

stefhak commented Apr 19, 2018

@lgrahl please provide a PR

@aboba aboba added Needs PR Discussion has converged - Pull Request needed and removed Needs assignee action labels Apr 19, 2018
@aboba aboba added PR exists and removed Needs PR Discussion has converged - Pull Request needed labels Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants