Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File a WebIDL issue to add the DOMException names WebRTC needs #495

Closed
foolip opened this issue Feb 10, 2016 · 12 comments
Closed

File a WebIDL issue to add the DOMException names WebRTC needs #495

foolip opened this issue Feb 10, 2016 · 12 comments
Assignees

Comments

@foolip
Copy link
Member

foolip commented Feb 10, 2016

The exception name is TBD in most places, but one place uses IdpError.

Please file an issue or pull request similar to whatwg/webidl#85 with the DOMException names this spec will used.

This came up in https://codereview.chromium.org/1661493002/

@burnburn
Copy link
Contributor

I think these have been addressed in tip-of-tree and should be visible with the next editor's draft publication to github.io.

@alvestrand
Copy link
Contributor

Adam will close this one when the new editors' draft with the fixes is pushed.

@alvestrand alvestrand assigned burnburn and unassigned adam-be Feb 11, 2016
@foolip
Copy link
Member Author

foolip commented Feb 13, 2016

So, in the end will no new DOMException names at all be needed? And where can I read the tip-of-tree version online?

@jan-ivar
Copy link
Member

@foolip https://w3c.github.io/webrtc-pc/ but it's not updated frequently enough.

What I do: Click "Code" tab above, then on "Latest commit xxx n days ago", then on View next to "webrtc.html", then Raw, then replace in URL "raw.githubusercontent.com" with "rawgit.com", then disable mixed-content protection.

E.g. https://rawgit.com/w3c/webrtc-pc/1949648d8cfc109bbc41a787a868adf16ce7af59/webrtc.html

@foolip
Copy link
Member Author

foolip commented Feb 15, 2016

Thanks @jan-ivar, it looks like the spec now uses NotSupportedError, NotReadableError and OperationError.

@jan-ivar
Copy link
Member

IdpLoginError is the only one that still sticks out to me. Although given its context, maybe it doesn't need to be a real error? @martinthomson

@burnburn
Copy link
Contributor

@martinthomson, would like your thoughts on jan-ivar's question. I had the same question.

@martinthomson
Copy link
Member

I think that it probably isn't an error. Maybe try to address that in a different issue though.

@dontcallmedom
Copy link
Member

so it sounds like this issue can be closed, and maybe @jan-ivar could raise a new one on whether IdPLoginError needs to be a real error.

@foolip
Copy link
Member Author

foolip commented Mar 17, 2016

I'm OK with closing this if a new issue to sort out https://w3c.github.io/webrtc-pc/#sec.idp-loginneeded is filed. Two things seem in need of some attention:

  1. Use of IdpLoginError without adding that to WebIDL (i.e. this issue, it was originally IdpError)
  2. "If the rejection object also contains a loginUrl attribute, this value will be passed to the application in the idpLoginUrl attribute." What does this mean? The loginUrl attribute isn't mentioned anywhere else, and the object with which the promise is rejected is a supposedly a DOMException which doesn't have that attribute.

@jan-ivar
Copy link
Member

@foolip that sounds like the right information. Want to file the issue?

@foolip
Copy link
Member Author

foolip commented Mar 17, 2016

I'd be delighted: #555

@foolip foolip closed this as completed Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants