Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertDTMF should normalize input #768

Closed
annevk opened this issue Aug 26, 2016 · 4 comments
Closed

insertDTMF should normalize input #768

annevk opened this issue Aug 26, 2016 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented Aug 26, 2016

Basically I'd use an ASCII uppercase operation. That makes it easier to write generic code that does something with the attribute values and is also somewhat good practice.

@aboba
Copy link
Contributor

aboba commented Sep 12, 2016

The spec refers to charcters A-D and says that "The characters a to d are equivalent to A to D." So it makes sense that a-d when entered are converted to ASCII upercase, and that browsers would only generate A-D.

@aboba
Copy link
Contributor

aboba commented Sep 15, 2016

In the merged PR, I added a statement about normalization. Are there places where it needs to be made clear that the browser always outputs normalized values?

@annevk
Copy link
Member Author

annevk commented Sep 15, 2016

The PR is mostly okay. The main problem is that it's not really phrased as a requirement, but rather as a statement of fact, yet nowhere is there a requirement that supports the statement of fact.

https://ln.hixie.ch/?start=1140242962&count=1 might help.

@alvestrand
Copy link
Contributor

Anne, are you saying that the statement "The characters a to d (normalized to uppercase on entry) are equivalent to A to D." should be phrased as "The characters a to d MUST be considered equivalent to A to D"? That's language not changed by this PR (despite being marked in red), so if so, there's a new issue. (The rest of the sentence is full of MUSTs, so count as normative conformance requirements in Hixie's taxonomy).

If you think this matters, please raise an issue on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants