Clarification on a stream receiving a FIN bit #36
Conversation
aboba
changed the title
|
@shampson Can you take a look? |
index.html
Outdated
| <li> The QUIC stream has received STREAM frame with the FIN flag set.</li> | ||
| for transmission, the write buffer to be cleared and <var>stream</var>'s | ||
| <a>[[\Writeable]]</a> slot to be set to <code>false</code>.</li> | ||
| <li><var>stream</var> has <a>finished reading</a>.</li> |
There was a problem hiding this comment.
Should this set [[Readable]] to false?
There was a problem hiding this comment.
Calling finish() causes a transition to closing with the [[Writeable]] slot false, but the [[Readable]] slot remains true until a FIN or RST_STREAM is received. This is shown in Figure 1.
There was a problem hiding this comment.
Right. This is saying we transition to closing when we've "finished reading," meaning if the stream has "read all available data up to the STREAM frame with the FIN bit set."
I'm asking if at that point the [[Readable]] slot should transition to false (because there's nothing to read anymore). If we also need to wait for finish() to be called, then it can stay as is.
There was a problem hiding this comment.
Yes, it should. Added text to make that clear.
index.html
Outdated
| @@ -953,7 +954,7 @@ <h2>Methods</h2> | |||
| slots to <code>false</code>.</li> | |||
| <li>Set <var>stream</var>'s <a>[[\QuicStreamState]]</a> slot to | |||
| <code>closing</code>.</li> | |||
| <li> If the <var>stream</var> has received a STREAM frame with the FIN bit set, | |||
| <li>If <var>stream</var> has <a>finished reading</a>, | |||
There was a problem hiding this comment.
Does this make sense? t seems to me that if you've received a FIN bit at this point you should transition to close, and it shouldn't depend on finishing reading. You can't read after this point anyways (reset() changes [[Readable]] to false).
This also contradicts 2. in the closed definition.
There was a problem hiding this comment.
Reverted the change in line 956/957. Does it make sense now?
| <p>The QUIC stream has been closed or could not be established. | ||
| This can happen in multiple ways:</p> | ||
| <p>The <code><a>RTCQuicStream</a></code> <var>stream</var> has been | ||
| closed or could not be established. This can happen in multiple ways:</p> | ||
| <ol> | ||
| <li>A RST_STREAM frame has been received.</li> | ||
| <li>A RST_STREAM frame has been sent and a STREAM frame |
There was a problem hiding this comment.
This bullet contradicts your change to reset().
There was a problem hiding this comment.
Change to reset() reverted, so should be consistent now.
|
Agree. Is the text consistent with that now? |
index.html
Outdated
| <li> The QUIC stream has received STREAM frame with the FIN flag set.</li> | ||
| for transmission, the write buffer to be cleared and <var>stream</var>'s | ||
| <a>[[\Writeable]]</a> slot to be set to <code>false</code>.</li> | ||
| <li><var>stream</var> has <a>finished reading</a>.</li> |
Fix for Issue #30