-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stat for adaptation reason #160
Comments
@alvestrand Is frameWidth/frameHeight the pre- or post degradation resolution? Spec says "represents the width of the video frame for this track". |
Is there a bitmask WebIDL type? frameWidth / frameHeight should be the "native resolution" you get if you connect that track to a |
Should we add actual video quality resolution as well? You probably know the size of the element already, but when you're gathering stats you want to know the current quality, no? |
the |
+@vr000m What is preferred if we don't have a bitmask, a boolean member for each option (adaptionReasonCpu, adaptionReasonNetwork) or a sequence of strings or sequence of enum (adaptionReasons with "cpu" and "network")? |
Related: Chromium's non-spec compliant version of getStats currently has:
|
What does CPU limited mean? |
My question here is what does it mean to be Bandwidth and CPU limited? And if I prefer to not change the Resolution in the degradation preference and it decreases, does this help me? |
There also was googViewLimitedResolution at some point, not sure what happened to it. I agree with either booleans or a repeated enum field. Bitmap is likely the most concise, but it also is less readable or understandable. I could definitely see additional values being added to this either by chrome or by another webrtc implementation. |
Alternatives:
|
Observation is "adaptation is happening". |
no meaning to the order of events. |
To be continued at #256 |
The resolution of a video track can adapt due to network or cpu limitations. It would be useful to have a stat to say if the framesWidth or framesHeight changed due to reasons of cpu, network or both.
This can be achieved with a bitmask or several booleans.
The text was updated successfully, but these errors were encountered: