Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing roundTripTime in RTCRemoteOutboundRtpStreamStats #602

Closed
minyuel opened this issue Apr 22, 2021 · 3 comments
Closed

missing roundTripTime in RTCRemoteOutboundRtpStreamStats #602

minyuel opened this issue Apr 22, 2021 · 3 comments
Labels
PR exists Ready for PR

Comments

@minyuel
Copy link
Contributor

minyuel commented Apr 22, 2021

roundTripTime (together with totalRoundTripTime and roundTripTimeMeasurements) is defined in RTCRemoteInboundRtpStreamStats (link), it is supposed to be calculated based on RTCP RR.

For receiving only streams, roundTripTime won't be based on RTCP RR, but can be based on RTCP XR SR (RFC 3611), then I think it ought be reported as one or more data field in RTCRemoteOutboundRtpStreamStats
@henbos
Copy link
Collaborator

henbos commented Apr 26, 2021

@alvestrand @vr000m Is this as simple as "let's add another RTT field to the RTCRemoteOutboundRtpStreamStats dictionary"? If so I'm happy to review a PR saying so

@vr000m
Copy link
Contributor

vr000m commented Apr 27, 2021

yes, this sounds appropriate if the XR is being implemented

@vr000m vr000m mentioned this issue Apr 27, 2021
Merged
@henbos
Copy link
Collaborator

henbos commented May 11, 2021

This issue is fixed since we merged #603

@henbos henbos closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR exists Ready for PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vr000m @alvestrand @minyuel @henbos