Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add framesDropped stats to video sender(RTCOutboundRtpStreamStats) #705

Closed
bdrtc opened this issue Oct 9, 2022 · 8 comments
Closed

add framesDropped stats to video sender(RTCOutboundRtpStreamStats) #705

bdrtc opened this issue Oct 9, 2022 · 8 comments

Comments

@bdrtc
Copy link
Contributor

bdrtc commented Oct 9, 2022

video frame maybe dropped prior to encode, according to webrtc code
the capture video frame maybe dropped by encoder's internal rate limiter or MediaOptimizations , but no stats about this now, its useful for diagnose online video problems, and the same stats exist in[RTCInboundRtpStreamStats.
we recommend add such stats to video sender side.

@lidp888
Copy link

lidp888 commented Oct 17, 2022

we add this in native code, add get via getStas, report to our diagnostic system for analize online user rtc problem.

@henbos
Copy link
Collaborator

henbos commented Oct 18, 2022

I think you can look at the delta between media-source.frames and outbound-rtp.framesEncoded

@vr000m
Copy link
Contributor

vr000m commented Oct 18, 2022

inputFrames and framesEncoded should give you this.

@bdrtc
Copy link
Contributor Author

bdrtc commented Oct 19, 2022

yes, user can calculate this via exist stats, but it leave complex to end user, the same stats exist in RTCInboundRtpStreamStats, but not exist in RTCOutboundRtpStreamStats, user may confused.

@vr000m
Copy link
Contributor

vr000m commented Oct 26, 2022

framesDiscardedBeforeSend is that the metric that you need? in this case, we should put it in to provisional-stats, unless this is going to be exposed by the browsers.

@henbos
Copy link
Collaborator

henbos commented Oct 27, 2022

libwebrtc has 185 implemented metrics (or 213 if you include some deprecated ones; 232 if you also include some that are not exposed to JavaScript). So as much as I like convenience, I'm opposed to adding metrics that are equivalent to "X - Y" of already exposed metrics.

@bdrtc
Copy link
Contributor Author

bdrtc commented Oct 27, 2022

framesDiscardedBeforeSend is that the metric that you need? in this case, we should put it in to provisional-stats, unless this is going to be exposed by the browsers.

not necessary,user want get it via getStats and report to a diagnostic system, we can get it via what @henbos described.

@henbos
Copy link
Collaborator

henbos commented Oct 27, 2022

👍

@henbos henbos closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants