-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add framesDropped stats to video sender(RTCOutboundRtpStreamStats) #705
Comments
we add this in native code, add get via getStas, report to our diagnostic system for analize online user rtc problem. |
I think you can look at the delta between media-source.frames and outbound-rtp.framesEncoded |
inputFrames and framesEncoded should give you this. |
yes, user can calculate this via exist stats, but it leave complex to end user, the same stats exist in RTCInboundRtpStreamStats, but not exist in RTCOutboundRtpStreamStats, user may confused. |
framesDiscardedBeforeSend is that the metric that you need? in this case, we should put it in to provisional-stats, unless this is going to be exposed by the browsers. |
libwebrtc has 185 implemented metrics (or 213 if you include some deprecated ones; 232 if you also include some that are not exposed to JavaScript). So as much as I like convenience, I'm opposed to adding metrics that are equivalent to "X - Y" of already exposed metrics. |
not necessary,user want get it via getStats and report to a diagnostic system, we can get it via what @henbos described. |
👍 |
video frame maybe dropped prior to encode, according to webrtc code
the capture video frame maybe dropped by encoder's internal rate limiter or MediaOptimizations , but no stats about this now, its useful for diagnose online video problems, and the same stats exist in[RTCInboundRtpStreamStats.
we recommend add such stats to video sender side.
The text was updated successfully, but these errors were encountered: