Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All promise rejections should say what they're rejected with #90

Closed
foolip opened this issue Sep 20, 2016 · 2 comments
Closed

All promise rejections should say what they're rejected with #90

foolip opened this issue Sep 20, 2016 · 2 comments
Milestone
1.0

Comments

@foolip
Copy link
Contributor

foolip commented Sep 20, 2016

https://w3c.github.io/webvr/#dom-vrdisplay-requestpresent
https://w3c.github.io/webvr/#dom-vrdisplay-exitpresent
https://w3c.github.io/webvr/#navigator-getvrdisplays-attribute

Some spec editors (@annevk) like TypeError for everything, but for user gesture there's precedent in HTML to use NotAllowedError.
@annevk
Copy link

annevk commented Sep 20, 2016 •
edited

But at a minimum, we should always reject with an Error class/subclass.

@toji toji added this to the 2.0 milestone Mar 16, 2017
@toji toji mentioned this issue May 16, 2018
Open
@toji
Copy link
Member

toji commented May 16, 2018

This issue was moved to immersive-web/webvr#24

@toji toji closed this as completed May 16, 2018
@cwilso cwilso modified the milestones: Spec-Complete for 1.0, 1.0 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@foolip @cwilso @toji @annevk