Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly handle NOTE blocks in the parser #221

Open
zcorpan opened this issue Oct 22, 2015 · 6 comments
Open

Explicitly handle NOTE blocks in the parser #221

zcorpan opened this issue Oct 22, 2015 · 6 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Oct 22, 2015

@foolip

zcorpan_: if you could also handle NOTE and explicitly ignore it, it would make it obvious how to avoid emitting console warnings for them in implementations

This is editorial but seems like a good idea to me.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 13, 2015

Depends on: #246

@zcorpan
Copy link
Member Author

zcorpan commented Nov 17, 2015

As part of this I plan to call out all the various places in the parsing algorithms where the input has syntax violations. Also editorial but very helpful for correctly logging syntax errors in browser devtools or in validators.

@foolip
Copy link
Member

foolip commented Nov 17, 2015

Yes, that would be great.

@dwsinger
Copy link

wow, yes

On Nov 17, 2015, at 4:20 , Philip Jägenstedt notifications@github.com wrote:

Yes, that would be great.


Reply to this email directly or view it on GitHub.

David Singer
Manager, Software Standards, Apple Inc.

@silviapfeiffer
Copy link
Member

Do we still need to do something about this? @BenjaminSchaaf has done some intensive testing of the parser code and #246 landed

@foolip
Copy link
Member

foolip commented Apr 18, 2017

It still isn't mentioned in the parser, so would be treated the same as an unrecognized chunk of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants