Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pptx for sixth video #73

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Conversation

idilsezgin
Copy link
Contributor

add pptx for sixth video for review.

@egekorkan egekorkan added the tutorial topics on our tutorials such as what is wot or quickstart label Sep 1, 2023
@egekorkan
Copy link
Collaborator

Feedback:

  • Basics slide can get some note text like "Let's start with basics"
  • Slide 8: Reference can be also understood as the $ref keyword so we should use a different word in the slide and in the notes. I would say "validation keywords" fit the slideset the best.
  • Slide 9: Type -> type AND restrict to a specific type
  • Slide 11: unnecessary comma in notes
  • Slide 15 has wrong code highlighting
  • Slide 18: It would be good to have examples of 0 or 1 not accepted
  • Slide 20: This one is advanced but let us explain it briefly. The contentMediaType keyword specifies the MIME type of the contents of a string, as described in RFC 2046. If you want to specify any type that is not JSON, it is possible to do this with contentMediaType keyword. The first one indicates a string containing an HTML document, encoded using the same encoding as the surrounding document: The second one indicates that a string contains a PNG image, encoded using Base64:

@egekorkan
Copy link
Collaborator

As discussed, the further review will happen when the videos are submitted. Merging

@egekorkan egekorkan merged commit 2316e14 into w3c:main Sep 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tutorial topics on our tutorials such as what is wot or quickstart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants