Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThingModel TypeScript defintition misses package-lock.json #379

Closed
danielpeintner opened this issue Feb 4, 2022 · 4 comments · Fixed by #386
Closed

ThingModel TypeScript defintition misses package-lock.json #379

danielpeintner opened this issue Feb 4, 2022 · 4 comments · Fixed by #386

Comments

@danielpeintner
Copy link
Contributor

see https://github.com/w3c/wot-scripting-api/tree/main/typescript/thing-model

Question:

  • Shall we add one
    OR
  • do we actually need it in general?
@relu91
Copy link
Member

relu91 commented Feb 4, 2022

thing-model is a subpackage of the Typescript project. Therefore the lock file is shared in the root folder:
https://github.com/w3c/wot-scripting-api/blob/main/typescript/package-lock.json

@danielpeintner
Copy link
Contributor Author

I see. On the other hand why do the other 2 TS subfolders have it ?

@relu91
Copy link
Member

relu91 commented Feb 7, 2022

I see. On the other hand why do the other 2 TS subfolders have it ?

Good point maybe is just a leftover 🤔 . Let me check!

@danielpeintner
Copy link
Contributor Author

today's scripting call

  • package-lock.json in sub-directories are to be removed
  • @danielpeintner will provide PR

@danielpeintner danielpeintner mentioned this issue Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove obsolete package-lock.json files in sub-directories
2 participants
@relu91 @danielpeintner