This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Use multiprocessing to somewhat speed up manifest generation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 74.86% (diff: 14.28%)@@ master #115 diff @@
==========================================
Files 17 17
Lines 1508 1512 +4
Methods 0 0
Messages 0 0
Branches 300 302 +2
==========================================
+ Hits 1130 1132 +2
Misses 333 333
- Partials 45 47 +2
|
|
In general LGTM. If updating the manifest is really a problem for WPT users we might want to look the overall strategy. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
@jgraham do we want to keep this open with your bigger rewrite looming? |
|
I'm not too attached to it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is