-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoinFabrik_On_Ink_Integration_Tests-2 #1043
Conversation
Thanks for the delivery @valeriacaracciolo we will take a look at it in the next couple of days. |
Thank you @keeganquigley We look forward to the review. Best, |
Hello, we noticed some failing checks with our PRs. We are working on resolving these issues and we estimate it should be solved by the end of next week. |
Hi @valeriacaracciolo sorry for the delay, we have been a bit behind due to recent organizational changes. I'm looking at this now. I see that one of the PRs in the delivery has been closed. Are there plans to re-open this? Also, the other two are still open. Have you talked to the team to see if there is a timeline as to when these can be looked at and merged? |
We explain below two changes that we had to perform to ensure that our PRs passed the corresponding checks, and to be consistent with new developments we have performed on other unimplemented functions in integration tests. We initially performed the Pull Request [#1963](use-ink/ink#1963) to implement instantiate_contract(), but decided to close it and perform a new Pull Request [#1988](use-ink/ink#1988) to include necessary implementations of other related functions, which were developed as a subsequent milestone to this Milestone 2. These functions were all related to each other, and a single PR seemed like the tidiest option. As part of an ad-hoc development in PR [#58] (use-ink/cargo-contract#1358), adding support to workspaces, we were requested to ensure that ink-examples worked correctly with this implementation. We initially performed the Pull Request [#44](use-ink/ink-examples#44) to show this. However, we had to close this PR because some modifications needed to be performed for checks to pass. We made these changes in Pull Request [#52](use-ink/ink-examples#52). We updated the Milestone Report and Table of Deliveries to reflect these final changes.
Thanks for the updates @valeriacaracciolo here you can find my final evaluation. I'm happy to pass the milestone and great job on the completion of the grant! |
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion. |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
Thank you for your evaluation @keeganquigley ! |
hi @valeriacaracciolo we just transferred the payment |
Thank you @RouvenP Received |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1980 < please fill this in with the PR number of your application.