Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement From<<Self as engine::EngineBLS>::PublicKeyGroupAffine> #18

Closed
drskalman opened this issue Oct 26, 2020 · 3 comments
Closed

implement From<<Self as engine::EngineBLS>::PublicKeyGroupAffine> #18

drskalman opened this issue Oct 26, 2020 · 3 comments
Assignees
@drskalman

Comments

@drskalman
Copy link
Collaborator

I have introduced auxaulary types PublicKey/SignaturePrepared to make the EngineBLS compatible with Zexe Curves but so I need to tell rust how to convert from pairing agnostic curves to the elements prepared specififcally for G1 or G2.
@drskalman drskalman self-assigned this Oct 26, 2020
@drskalman drskalman added the sync label Oct 26, 2020
@burdges
Copy link
Collaborator

burdges commented Oct 26, 2020

If I understand then I did with the two impls for EngingBLS

@drskalman drskalman removed the sync label Oct 27, 2020
@drskalman
Copy link
Collaborator Author

One actually need to implements From for G1Prepared and G2Prepared and then just tell rust that which one is PublicKeyPrepared and SignaturePrepared is. On the other hand these are implemented in each model (BLS12, ...) in the Zexe crate. So I don't think there is more to do with this at least for now.

@burdges
Copy link
Collaborator

burdges commented Oct 27, 2020

yes you coudl not impl From for a foreign type anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drskalman drskalman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burdges @drskalman