Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review, verify, clean up and update README.md #38

Closed
3 tasks done
drskalman opened this issue Nov 4, 2021 · 3 comments
Closed
3 tasks done

Review, verify, clean up and update README.md #38

drskalman opened this issue Nov 4, 2021 · 3 comments
Assignees
@drskalman

Comments

@drskalman
Copy link
Collaborator

drskalman commented Nov 4, 2021 •
edited
Loading

Check if the fact mentioned in the README.md of the crate is still relevant and if the README code compiles. Additionally:

  • Emphasize on simple cases so we do not scare people out: One messaged singed by two party according to IETF proposal.
  • Add explanation for the hash to curve because the library is opinionated about it.
  • Explain Schnorr pop.
@drskalman drskalman self-assigned this Nov 4, 2021
@drskalman
Copy link
Collaborator Author

62e0c8a should acomplish all goals mentioned in the ticket. I'll ask @burdges or @AlistairStewart to go over it and then we should be OK to close this.

1 similar comment
@drskalman
Copy link
Collaborator Author

62e0c8a should acomplish all goals mentioned in the ticket. I'll ask @burdges or @AlistairStewart to go over it and then we should be OK to close this.

@drskalman
Copy link
Collaborator Author

This was reviewed @burdges and approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drskalman drskalman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drskalman