-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test vectors #36
Comments
We'll need them eventually of course. I'd accept PRs for them now. And we've commented out code that gives a starting point. I've only just made a bunch of breaking changes, so test vectors would've made no sense before now. We could either add some now, as this might be the last batch of breaking changes, or else wait until we get a bit more feedback. Ideally, we might do #26 before adding test vectors so as to suggest breaking optimizations. I halfway implemented #26 once before though so I think the only breaking optimizations is already done in https://github.com/w3f/schnorrkel/blob/master/src/vrf.rs#L736 |
In any case, I think benchmarks are a much higher priority. We'll always support merlin, and should've test vectors, but we might recommend alternative hashing with Shake128 or Blake2x instead of merlin. See #33 |
We should be ready to settle on test vectors around early August. |
We've settled everything so this can proceed. |
I'll close in favor of #43 |
Adding some test vectors may be helpful to ensure internal consistency.
The text was updated successfully, but these errors were encountered: