Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility between Starsig and Schnorrkel #51

Closed
oleganza opened this issue Nov 18, 2019 · 6 comments
Closed

Compatibility between Starsig and Schnorrkel #51

oleganza opened this issue Nov 18, 2019 · 6 comments

Comments

@oleganza
Copy link

Hi,

I'd like to make Starsig and Schnorrkel compatible and maybe bikeshed the labels a little. Have you deployed Schnorrkel already, is it hard to update the labels? Would love to hear your thoughts on this: stellar/slingshot#382

Thanks!

@burdges
Copy link
Collaborator

burdges commented Nov 18, 2019

Yes, it's deployed in kusama, but not yet in polkadot. It'd be tricky to change anything, although maybe not impossible if I can sell the devs on the change being important enough to justify keeping two versions of schnorrkel around.

@burdges
Copy link
Collaborator

burdges commented Nov 18, 2019

Just fyi I think #45 will be the most annoying label mess here. If we do have a very good reason to change labels elsewhere, then maybe I'd try to deal with that in a better way than proposed in that issue. It's quite tricky to sell though.

@burdges
Copy link
Collaborator

burdges commented Nov 18, 2019

It'd be very hard to convince folks to throw kusama users under the bus actually. I've long hoped kusma would be a short lived "game of stakes" style thing, but not likely. The branding is too amusing and folks are even discussing tattoos I hear. lol

@burdges
Copy link
Collaborator

burdges commented Jan 5, 2020

I suppose accepting both labels might be one option for compatibility. We could probably feature gate the label choice somehow, or build it into the SigningTranscript.

@burdges
Copy link
Collaborator

burdges commented Aug 25, 2020

I suppose our having selected prefix free labels maybe improves something somewhere:
dalek-cryptography/merlin#62 (comment)

@burdges
Copy link
Collaborator

burdges commented Feb 15, 2022

We'll close this since everything is well established now.

@burdges burdges closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants