You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We store hashes of each direct descendant's Storkable::value in each Storkable as a fix for #1 and we don't expose this to consumers. Right now consumers have to create a flat Vec and hash each Storkable::value themselves to check if they've seen the link before - even if they've all come from the same parent.
We need to figure out a good API to see if a "value" has been seen before from any parent, for example if the heirarchy looks like this:
root
↳ 123
↳ 456
↳ 789
↳ abc
↳ def
↳ ghi
We'd expect root.seen(789) and 123.seen(456) to be true but 456.seen(123) or abc.seen(123) not to be.
Right now children only hold references to their parents and not vice-versa so this lookup can currently only be done in reverse.
The text was updated successfully, but these errors were encountered:
w4
changed the title
Expose a way to check if a link has been seen before
Expose a way to check if a value has been seen before
Feb 15, 2020
We store hashes of each direct descendant's
Storkable::value
in eachStorkable
as a fix for #1 and we don't expose this to consumers. Right now consumers have to create a flatVec
and hash eachStorkable::value
themselves to check if they've seen the link before - even if they've all come from the same parent.We need to figure out a good API to see if a "value" has been seen before from any parent, for example if the heirarchy looks like this:
We'd expect
root.seen(789)
and123.seen(456)
to be true but456.seen(123)
orabc.seen(123)
not to be.Right now children only hold references to their parents and not vice-versa so this lookup can currently only be done in reverse.
The text was updated successfully, but these errors were encountered: