Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: adapter disconnect #2

Closed
intech opened this issue Aug 24, 2021 · 1 comment
Closed

bug: adapter disconnect #2

intech opened this issue Aug 24, 2021 · 1 comment

Comments

@intech
Copy link

intech commented Aug 24, 2021

/**
* Disconnect from database.
*
* @methods
*
* @returns {Promise}
*/
disconnect() {
this.adapter.connect();
return Promise.resolve();
},

Need adapter.disconnect()? And there is no need to return resolve for all methods.

@Waddah-JD
Copy link
Owner

thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants