-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase flexibility of visual reports #730
Comments
Moving the |
|
The only "limitation" I see to that option is that we would need to either always export the timeseries from Exporting always the part 5 timeseries could make the function slower, which is not good. So, the option I see is to state in the in the new package that part5 timeseries should be exported for the visualization to work. |
I am not proposing exporting the time series. My proposal is that the new package, lets call it GGIRvisual for now, provides a function that takes as input all the information needed for creating the visualisation ranging form part 2 time series to part 5 classification. Next, g.part5 would call this external function and give it all the information it needs. The output of the external function would be the visualisation which GGIR can then send to a pdf for example. Ideally GGIRvisual is not used by GGIR users directly, but as a dependency just like GGIRread is. But just like GGIRread we would design GGIRvisual in a way that it can be used without GGIR. |
I see, sounds good. I can start working on this. Should we then migrate all the visualizations made by GGIR? Or just the file summary reports for now? |
I think it is good to plan this with all GGIR plotting functionality in mind even if we practically start with just one visualisation. This would then be a good opportunity to:
|
Closing this issue, as we are not planning to work on this anytime soon. |
We discussed this some time ago. File summary reports look well when GGIR is run on defaults (ENMO, worn on wrist, standard bout lengths, ...). But they can be improved if other settings are used. For example:
For now I am just creating this issue not to forget it and to make a list of the things we would like to improve in g.plot5.
The text was updated successfully, but these errors were encountered: