Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the project from Eclipse #112

Closed
dblock opened this issue Jul 11, 2014 · 6 comments
Closed

Build the project from Eclipse #112

dblock opened this issue Jul 11, 2014 · 6 comments
Labels

Comments

@dblock
Copy link
Collaborator

dblock commented Jul 11, 2014

Importing projects from Eclipse doesn't import the things in ThirdParty under _lib, so cannot build :(

@hazendaz Am I doing it wrong?

@hazendaz
Copy link
Member

ThirdParty just has the very few jars that are not in maven central and would otherwise require an individual nexus repo to house. The maven builds for tomcat5 & spring-security4 are the only pieces that reference Third Party. Under the help document images there are images of how to get everything imported into eclipse. Because this is a multi module build now, it needs to have all pieces imported in so that things build properly.

From a command line, if you have maven added to your path variable and have rebooted your machine, you can run 'mvn clean install' directly in the 'waffle-parent' project. That will cause it to build everything. I verified last night no issues there.

@hazendaz
Copy link
Member

Looking at some of the older images from being this went fully to maven. I do see that thirdParty used to be pulled in. Since that piece use to house the ant/ivy integration, that is likely why you saw it being imported before. Now it no longer needs imported. Maven gets to what it needs in the directory tree without issue. It should work in windows/*nix the same.

@hazendaz
Copy link
Member

I've created a windows bat file under ThirdParty that will install the jars there into the local maven repo. So 5 jars, the 3 tomcat & 2 spring security. I'm working off the mainline so I'm holding off posting all this until the tests are resolved. If you want to just accept those for now, I will then perform and merge in a change request with updated documents, waffle distro build (directory file result), and this batch file. This is not to a completed state but does completely build and probably would help if we were both seeing this moving forwards. Second set of 'eyes' 👍

@dblock
Copy link
Collaborator Author

dblock commented Jul 12, 2014

I'll deal with Eclipse later, lets first fix the command line build, #109.

@hazendaz
Copy link
Member

I must have been following this incorrectly. So this is the waffle.proj that is at issue. It no longer needs to copy anything from java side except the distro. Will leave this open until new pull request is reviewed and applied. I attempted to cleanup all the items out of waffle.proj that are no longer needed since maven handles that. In fact, might be able to make maven handle nearly all of it. So more to come there.

@hazendaz
Copy link
Member

This is working now so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants