Tests failing when using django-storages (S3BotoStorage)

[salvadormrf]

requirements

boto==2.38.0
django-storages==1.1.8

settings

DEFAULT_FILE_STORAGE = 'storages.backends.s3boto.S3BotoStorage'
AWS_S3_SECURE_URLS = True       # use http instead of https
AWS_QUERYSTRING_AUTH = False    # don't add complex authentication-related querying

AWS_S3_ACCESS_KEY_ID = 'MY-KEY'
AWS_S3_SECRET_ACCESS_KEY = 'MY-SECRET'
AWS_STORAGE_BUCKET_NAME = 'MY-BUCKET'

result

python runtests.py wagtail.wagtailimages --failfast

======================================================================
FAIL: test_closes_image (wagtail.wagtailimages.tests.test_models.TestGetWillowImage)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/wagtail-1.0/wagtail/wagtailimages/tests/test_models.py", line 239, in test_closes_image
    self.assertTrue(self.image.file.closed)
AssertionError: False is not true

----------------------------------------------------------------------
Ran 4 tests in 2.563s

FAILED (failures=1)
Destroying test database for alias 'default'...

[kaedroho]

This looks like a bug in django-storages to me.

When you call file.close() the file.closed property should return True.

django-storages doesn't override djangos default definition of this property: https://github.com/django/django/blob/master/django/core/files/base.py#L67-L69

This tells if the file is closed by simply accessing the .file attribute. But in django-storages, this reopens the file: https://github.com/jschneier/django-storages/blob/master/storages/backends/s3boto.py#L120-L138

So .closed returns False

[kaedroho]

Closing as this isn't a Wagtail bug