Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a comments popup #23

Merged
merged 9 commits into from
Jan 4, 2023
Merged

Create a comments popup #23

merged 9 commits into from
Jan 4, 2023

Conversation

Lucas-Erkana
Copy link
Collaborator

@Lucas-Erkana Lucas-Erkana commented Jan 4, 2023

✅ Setup linters
✅Add event to the button
✅Add JavaScript that will ensure the popup loads
✅Upon clicking on a button data will be retrieved from the selected API and shows details about the selected item
✅ Apply styling to the popup
✅ Add video frames for each popup

@Lucas-Erkana Lucas-Erkana self-assigned this Jan 4, 2023
@Lucas-Erkana Lucas-Erkana added the enhancement New feature or request label Jan 4, 2023
Copy link
Owner

@Wahaj-Ali Wahaj-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popup window for selected items ✅
No linter errors ✅
Followed JavaScript best practices ✅
Used ES6 syntax ✅
Used callbacks and promises ✅

There is nothing to do as your task is complete..its time to merge.

@Lucas-Erkana Lucas-Erkana merged commit 992d837 into dev Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4pt] -Display Comments pop up with selected item's details - Student B
2 participants