Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment counter and display on popup #29

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

Lucas-Erkana
Copy link
Collaborator

✅ No Linter errors
✅ Counter implemented as a separate module
✅ Counter function is looking for a specific DOM elements
✅ Make the counting based on what is actually displayed on the page
✅ Counter is displayed on each poup

@Lucas-Erkana Lucas-Erkana linked an issue Jan 5, 2023 that may be closed by this pull request
@Lucas-Erkana Lucas-Erkana self-assigned this Jan 5, 2023
@Lucas-Erkana Lucas-Erkana added the enhancement New feature or request label Jan 5, 2023
Copy link
Owner

@Wahaj-Ali Wahaj-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Linter errors
✅ Counter implemented as a separate module
✅ Counter function is looking for specific DOM elements
✅ Make the counting based on what is actually displayed on the page
✅ Counter is displayed on each poup
Your task is complete. Its time to merge

@Wahaj-Ali Wahaj-Ali merged commit 449e585 into dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] - Add comments counter - Student B
2 participants