-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python in msys2 #124
Fix python in msys2 #124
Conversation
shutil.copy2(getCliLocation(), link) | ||
except: | ||
log(traceback.format_exc()) | ||
if not exists: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change this to try copying even when already exists, but only if we've successfully downloaded an updated wakatime-cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let job_cmd = split(&shell) + split(&shellcmdflag) + cmd | ||
else | ||
let job_cmd = split(&shell) + split(&shellcmdflag) + [s:JoinArgs(cmd)] | ||
if s:IsWindows() && s:Chomp(system(s:JoinArgs([python_bin, '-VV'])) !~ 'MSC') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use system()
during init because it slows down startup for all Windows users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work instead?
vim-wakatime/plugin/wakatime.vim
Line 94 in bbfa0fb
if s:IsWindows() && &shell =~ '/msys' |
Closing in favor of 1ebea7d. |
No description provided.