Fix python in msys2 #124
Closed
Fix python in msys2 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhamlett
reviewed
Jan 7, 2022
| shutil.copy2(getCliLocation(), link) | ||
| except: | ||
| log(traceback.format_exc()) | ||
| if not exists: |
There was a problem hiding this comment.
I'll change this to try copying even when already exists, but only if we've successfully downloaded an updated wakatime-cli.
alanhamlett
reviewed
Jan 7, 2022
| let job_cmd = split(&shell) + split(&shellcmdflag) + cmd | ||
| else | ||
| let job_cmd = split(&shell) + split(&shellcmdflag) + [s:JoinArgs(cmd)] | ||
| if s:IsWindows() && s:Chomp(system(s:JoinArgs([python_bin, '-VV'])) !~ 'MSC') |
There was a problem hiding this comment.
We can't use system() during init because it slows down startup for all Windows users.
There was a problem hiding this comment.
This should work instead?
vim-wakatime/plugin/wakatime.vim
Line 94 in bbfa0fb
|
Closing in favor of 1ebea7d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.