fix: filter for wss in libp2p websocket transport #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
adklempner
force-pushed
the
fix/transport-filter-wss
branch
from
ba38972
to
cbddc74
Compare
adklempner
force-pushed
the
fix/transport-filter-wss
branch
from
cbddc74
to
5ffe187
Compare
weboko
reviewed
Apr 30, 2024
packages/sdk/src/utils/libp2p.ts
Outdated
| @@ -64,11 +64,16 @@ export async function defaultLibp2p( | |||
| ? { metadata: wakuMetadata(shardInfo) } | |||
| : {}; | |||
|
|
|||
| const filter = | |||
| typeof process !== "undefined" && process?.env?.NODE_ENV === "test" | |||
There was a problem hiding this comment.
let's handle this the same way it happens here -
js-waku/packages/sdk/rollup.config.js
Line 25 in 3d92f19
this way we don't need to worry about process not being defined or even passing process.env.NODE_ENV
There was a problem hiding this comment.
updated. tested it in light-js by making a release from this branch and made sure the replacement works
adklempner
force-pushed
the
fix/transport-filter-wss
branch
from
5ffe187
to
682cc66
Compare
3 tasks
weboko
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current libp2p transport filter allows all connections. This is fine for testing, but in production we want to limit transports to secure WebSockets (wss or tls/ws).
Solution
Allow all transport types when running tests by setting
process.env.NODE_ENV=testbut otherwise use the libp2p filter for secure websockets peersNotes
Contribution checklist:
!in title if breaks public API;