feat: only dial a peer if it has a wss multiaddr #1983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
feat/only-dial-wss
branch
from
dfe7320
to
789a5e1
Compare
size-limit report 📦
|
| const peer = await this.libp2p.peerStore.get(peerId); | ||
|
|
||
| if ( | ||
| !peer.addresses.some((val) => val.multiaddr.toString().includes("/wss/")) |
There was a problem hiding this comment.
know it's not for review yet but came here to mention the address can also be of the format /tls/ws/
|
nice! |
|
@danisharora099 I found an another way to do this by updating libp2p settings: https://github.com/waku-org/js-waku/pull/1989/files Although this updates it so that the peers without wss don't end up in the peer store at all, whereas the method in this PR still has them in the peer store, it just doesn't attempt to make connections. Do you know if there's a benefit to having peers in the store even if we can't connect to them? |
|
closing in favor of #1989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Connection manager will attempt to dial a peer even if the peer doesn't have a wss multiaddr. This leads to a lot of failing dials with the error
"The dial request has no valid addresses"Solution
When checking if a peer should be dialed, get the peer info from the peer store and skip dialing if none of the multiaddrs use wss
Notes
Contribution checklist:
!in title if breaks public API;