Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add payload bytes to trace log #1703

Merged
merged 1 commit into from
Apr 25, 2023
Merged

chore: add payload bytes to trace log #1703

merged 1 commit into from
Apr 25, 2023

Conversation

alrevuelta
Copy link
Contributor

closes #1701

@@ -241,7 +241,8 @@ proc registerRelayDefaultHandler(node: WakuNode, topic: PubsubTopic) =
peerId=node.peerId,
pubsubTopic=topic,
hash=topic.digest(msg).to0xHex(),
receivedTime=getNowInNanosecondTime()
receivedTime=getNowInNanosecondTime(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use snake_case instead?

Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alrevuelta alrevuelta merged commit c6d291d into master Apr 25, 2023
@alrevuelta alrevuelta deleted the log-msg-size branch April 25, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Expand logging for Waku e2e message traceability with the payload message size in bytes.
4 participants