Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): remove registration capability #1916

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 18, 2023

Description

Removes rln registration capabilities from wakunode2 and chat2, but preserves the functionality as requested by @jm-clius

Changes

  • Remove --rln-eth-account-private-key from the wakunode2 and chat2 configs
  • Modify the WakuRlnConfig object to not take in a private key
  • Modify the tutorial docs

Issue

closes #1887

@rymnc rymnc self-assigned this Aug 18, 2023
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1916

@rymnc rymnc force-pushed the remove-rln-registration-capability branch from 03597f8 to 9002723 Compare August 18, 2023 10:31
@rymnc
Copy link
Contributor Author

rymnc commented Aug 18, 2023

A follow up PR will be created to abstract the functionality of

  1. creating identity credentials
  2. registering them onchain
  3. creating a keystore

into its own app/

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Way better to split the rln registration from wakunode2. And like that we also avoid providing private keys to the waku node.

@rymnc rymnc force-pushed the remove-rln-registration-capability branch from 9002723 to 3c378ed Compare August 21, 2023 11:08
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@rymnc rymnc merged commit f08315c into master Aug 22, 2023
12 checks passed
@rymnc rymnc deleted the remove-rln-registration-capability branch August 22, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore(rln-relay): remove registration capabilities
3 participants