Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rln): init rln_keystore_generator #1925

Merged
merged 2 commits into from
Aug 22, 2023
Merged

feat(rln): init rln_keystore_generator #1925

merged 2 commits into from
Aug 22, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 22, 2023 •
edited

Description

Initializes a new app called rln_keystore_generator which will take care of the following -

  1. generate identity_credentials
  2. write to local keystore
  3. (optional) register on-chain

Changes

  • Updated Makefile, waku.nimble and created the barebones app/

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1925

@rymnc rymnc marked this pull request as ready for review August 22, 2023 09:22
@rymnc rymnc self-assigned this Aug 22, 2023
jm-clius
jm-clius approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that I would suggest having this under /tools and not /apps. Apps are applications built on top of a Waku node.

@alrevuelta alrevuelta mentioned this pull request Aug 22, 2023
Closed
56 tasks
alrevuelta
alrevuelta approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Used waku-org/go-waku#654 and works like charm. Guess for completiness its nice to have it also in nwaku, so thanks for this.

@rymnc
Copy link
Contributor Author

rymnc commented Aug 22, 2023

LGTM, except that I would suggest having this under /tools and not /apps. Apps are applications built on top of a Waku node.

Addressed in 8f26627

@rymnc rymnc merged commit 3d84954 into master Aug 22, 2023
12 checks passed
@rymnc rymnc deleted the rln-credential-tool branch August 22, 2023 14:23
@rymnc rymnc mentioned this pull request Aug 22, 2023
Merged
3 tasks
@rymnc rymnc mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrevuelta alrevuelta alrevuelta approved these changes

@jm-clius jm-clius jm-clius approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rymnc @alrevuelta @jm-clius