Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validation mechanism to limit "free traffic" on the network #1938

Closed
chair28980 opened this issue Aug 23, 2023 · 4 comments
Closed

feat: Validation mechanism to limit "free traffic" on the network #1938

chair28980 opened this issue Aug 23, 2023 · 4 comments

Comments

@chair28980
Copy link
Contributor

This tracks the work to define and implement a relay validator that allows nodes to limit the amount of bandwidth they're willing to allocate for routing "free traffic". In this case, "free traffic" would be Waku messages with no RLN proofs.

Priority: Critical for launch

@rymnc
Copy link
Contributor

rymnc commented Aug 24, 2023

note: this feature exists within the WakuRlnRelay validator, and needs to be separated from it

before we do that though, we need to ensure ordered execution of validators, which currently happens in parallel in nim-libp2p

  1. WakuMessage decoding
  2. Bandwidth rate limiting
  3. RLN validator
  4. any other validator

@alrevuelta
Copy link
Contributor

A clarification on

they're willing

Nodes can't chose this parameter. It will be hardcoded, to ensure that every node views the same message as valid/invalid. Note still that even with this some messages may be wrongly labeled, due to some minor delays in the network. So not a feature that I really like tbh.

before we do that though, we need to ensure ordered execution of validators, which currently happens in parallel in nim-libp2p

Im checking this with libp2p team. Quickest solution would be to merge all validators into one so that we can control the order, but checking with them the rationale behind i) running them in paralel and ii) not guaranteeing the order.

@chair28980
Copy link
Contributor Author

Work to be descoped from Gen 0 milestone, per discussion in nwaku pm meeting 2023-11-21.

@chair28980
Copy link
Contributor Author

De-scoped indefinitely until need is established.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants