Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): updated docs #1993

Merged
merged 1 commit into from
Sep 11, 2023
Merged

chore(rln-relay): updated docs #1993

merged 1 commit into from
Sep 11, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 6, 2023

Description

This PR updates the contract address in documentation, and includes docs for rln-keystore-generator

Changes

  • rln-keystore-generator docs
  • updated contract address

@rymnc rymnc self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1993

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:1993-experimental

2. Define the arguments you wish to use

```bash
export RPC_URL="https://sepolia.infura.io/v3/..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide .env.example with all these env vars (although some having example or empty values) rather than have a bunch of copies of these exports at various places - here, run-with-rln.md, onchain-rln-relay-chat2 has the values too (and could also reference the import/sourcing of .env)

It would potentially help us (you:) ) with keeping all the places referencing these in sync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - follow up pr for this!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🚀

@rymnc rymnc merged commit 76e3407 into master Sep 11, 2023
14 checks passed
@rymnc rymnc deleted the rln-relay-docs-update branch September 11, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants