fix(tests): relay tests use random port to avoid conflict #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the experimental image built from this PR at |
|
You can find the image built from this PR at |
SionoiS
requested review from
vpavlin,
alrevuelta,
jm-clius,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
Ivansete-status
approved these changes
Sep 7, 2023
alrevuelta
approved these changes
Sep 7, 2023
vpavlin
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've looked at all the tests to see if
Port()had any conflicts and fixed what I could.If we still have conflicts, in the future, adding a
randomPort()could do the trick.Changes
waku_relaytests now usePort(0)instead of hardcoded ports.test_rest_storenow use port 58011-58016 instead of the same port.Closes #1826