Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rln_db_inspector): create rln_db_inspector tool #1999

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 7, 2023

Description

While debugging and running simulations, it can be useful to inspect the rln tree db.
Future PRs can add more inspection capabilities, but this will be useful for now.

Changes

  • new tool rln_db_inspector
  • updated makefile entry and waku.nimble

How to test

  1. Have a pre-existing rln tree db (from running wakunode2)
  2. Compile the binary make -j12 rln-db-inspector
  3. Run ./build/rln-db-inspector --rln-relay-tree-path:<path>
image

@rymnc rymnc self-assigned this Sep 7, 2023
@rymnc rymnc marked this pull request as ready for review September 7, 2023 04:40
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1999

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:1999-experimental

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

tools/rln_db_inspector/external_config.nim Outdated Show resolved Hide resolved
tools/rln_db_inspector/rln_db_inspector.nim Outdated Show resolved Hide resolved
Co-authored-by: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com>
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool:)

@rymnc rymnc merged commit ec42e2c into master Sep 7, 2023
14 checks passed
@rymnc rymnc deleted the inspect-db-tool branch September 7, 2023 12:45
@alrevuelta
Copy link
Contributor

This tool saved the day today in debugging! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants