chore: move SubscriptionManager under waku_core #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and SubscriptionManager from Filter V1 to under waku_core
NagyZoltanPeter
added
the
E:REST API service node
NagyZoltanPeter
requested review from
SionoiS,
gabrielmer and
Ivansete-status
|
You can find the image built from this PR at Built from 3548e97 |
gabrielmer
reviewed
Sep 12, 2023
SionoiS
approved these changes
Sep 12, 2023
|
LGTM :):) |
gabrielmer
approved these changes
Sep 12, 2023
NagyZoltanPeter
deleted the
chore/place-subscription-manager-out-of-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick fromFilter V2 Rest API PR to separate one.
FilterV1 client hold FilterPushHandler and SubscriptionManager which was not the right place to import from.
Better moved to under waku_core/subscription to be easily reused.
How to test
All existing tests on Waku Filter (v1 or legacy) covers the change properly.