fix: libwaku.nim: unsubscribe -> unsubscribeAll to make it build properly #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced a change in the next PR https://github.com/waku-org/nwaku/pull/1983/files that made the `libwaku` to stop building properly (make libwaku) because a signature change in the `unsubscribe` proc of waku/waku_relay/protocol.nim. This commit is a temporary workaround to make it work, and not block any ongoing PR tests, although not exactly as it is expected because we are unsubscribing from all topics.
vpavlin
approved these changes
Sep 26, 2023
|
You can find the image built from this PR at Built from 3d551b8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We introduced a change in the next PR
#1983
that made the
libwakustop building properly(make libwaku) because a signature change in the
unsubscribeproc of waku/waku_relay/protocol.nim.This PR is a temporary workaround to make it work, and not block any ongoing PR tests,
although not it doesn't not work exactly as expected because we are unsubscribing from all topics.