chore: Optimize postgres - prepared statements in select #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 22d53a8 |
Ivansete-status
changed the title
Ivansete-status
requested review from
SionoiS,
alrevuelta,
jm-clius and
NagyZoltanPeter
SionoiS
approved these changes
Nov 6, 2023
SionoiS
approved these changes
Nov 6, 2023
NagyZoltanPeter
approved these changes
Nov 7, 2023
| ## but, on the other hand, the connection remains in "db.pqisBusy() == 1" for 100ms more. | ||
| ## I think this is because `nwaku` is single-threaded and it has to handle many connections (20) | ||
| ## simultaneously. Therefore, there is an underlying resource sharing (cpu) that makes this | ||
| ## to happen. Notice that the _Postgres_ database spawns one process per each connection. |
There was a problem hiding this comment.
I appreciate this great, explanatory comment here!!!
|
|
||
| return ok(rows) | ||
|
|
||
| method getMessages*(s: PostgresDriver, |
There was a problem hiding this comment.
How come PostgresDriver reference named as "s"? :-)
There was a problem hiding this comment.
Thanks for the comments! I'll review that in upcoming refactoring PRs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The prepared statements is a mechanism that allows saving time for common queries.
We are applying that approach for the "select" queries, i.e. queries that come from the Store protocol requests. Notice that we were already applying this in "insert" operations.
With that, we enhance the performance of "select" queries. However, bear in mind that there is an underlying time consumption when performing concurrent queries. I've added a long comment about that in
dbconn.nim.Changes
Issue
#1842