Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vendor bump for v0.25 #2352

Merged
merged 2 commits into from
Jan 30, 2024
Merged

chore: vendor bump for v0.25 #2352

merged 2 commits into from
Jan 30, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jan 12, 2024

Description

Vendor version bump for v0.25

nim-web3 contains changes that affect RLN. I tried to update the RLN code but I lack context.

Are you guys going to take care of the update? @alrevuelta @rymnc ?

Issue

#2344

@SionoiS SionoiS self-assigned this Jan 12, 2024
Copy link

github-actions bot commented Jan 12, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2352

Built from a000898

@SionoiS SionoiS marked this pull request as ready for review January 15, 2024 12:51
@SionoiS SionoiS added the release Tracks releases label Jan 15, 2024
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Ivansete-status
Copy link
Collaborator

Thanks for this @SionoiS !
However, I have the impression that we cannot merge it until determining why some js-waku tests fail:
image

@SionoiS
Copy link
Contributor Author

SionoiS commented Jan 29, 2024

Thanks for this @SionoiS ! However, I have the impression that we cannot merge it until determining why some js-waku tests fail:

I re-ran the tests and it still fail but with seemingly unrelated errors...

@Ivansete-status
Copy link
Collaborator

@SionoiS - I've run the js-waku tests with multiple versions (v0.23.0 & v0.24.0) and each time they fail ~6 tests. I think this can be merged :)

@fbarbu15 - We will need your help, when you have some time, to determine why these tests are failing now.
I leave a copy of the results after running js-waku tests against v0.24.0:

  1) Waku Filter V2: Subscribe: Single Service Node
       Subscribe to 100 topics (new limit) at once and receives messages:
     Error: Error subscribe all peers: Error subscribing to peer: 16Uiu2HAmUK5EPJWt8w9v1PSW4WM4ETqarpUwRabfAfKub4ptdRg2 for content topics: /test/1/waku-multi,/test/2/waku-multi,/test/3/waku-multi,/test/4
/waku-multi,/test/5/waku-multi,/test/6/waku-multi,/test/7/waku-multi,/test/8/waku-multi,/test/9/waku-multi,/test/10/waku-multi,/test/11/waku-multi,/test/12/waku-multi,/test/13/waku-multi,/test/14/waku-mul
ti,/test/15/waku-multi,/test/16/waku-multi,/test/17/waku-multi,/test/18/waku-multi,/test/19/waku-multi,/test/20/waku-multi,/test/21/waku-multi,/test/22/waku-multi,/test/23/waku-multi,/test/24/waku-multi,/
test/25/waku-multi,/test/26/waku-multi,/test/27/waku-multi,/test/28/waku-multi,/test/29/waku-multi,/test/30/waku-multi,/test/31/waku-multi,/test/32/waku-multi,/test/33/waku-multi,/test/34/waku-multi,/test/35/waku-multi,/test/36/waku-multi,/test/37/waku-multi,/test/38/waku-multi,/test/39/waku-multi,/test/40/waku-multi,/test/41/waku-multi,/test/42/waku-multi,/test/43/waku-multi,/test/44/waku-multi,/test/45/waku-multi,/test/46/waku-multi,/test/47/waku-multi,/test/48/waku-multi,/test/49/waku-multi,/test/50/waku-multi,/test/51/waku-multi,/test/52/waku-multi,/test/53/waku-multi,/test/54/waku-multi,/test/55/waku-multi,/test/56/waku-multi,/test/57/waku-multi,/test/58/waku-multi,/test/59/waku-multi,/test/60/waku-multi,/test/61/waku-multi,/test/62/waku-multi,/test/63/waku-multi,/test/64/waku-multi,/test/65/waku-multi,/test/66/waku-multi,/test/67/waku-multi,/test/68/waku-multi,/test/69/waku-multi,/test/70/waku-multi,/test/71/waku-multi,/test/72/waku-multi,/test/73/waku-multi,/test/74/waku-multi,/test/75/waku-multi,/test/76/waku-multi,/test/77/waku-multi,/test/78/waku-multi,/test/79/waku-multi,/test/80/waku-multi,/test/81/waku-multi,/test/82/waku-multi,/test/83/waku-multi,/test/84/waku-multi,/test/85/waku-multi,/test/86/waku-multi,/test/87/waku-multi,/test/88/waku-multi,/test/89/waku-multi,/test/90/waku-multi,/test/91/waku-multi,/test/92/waku-multi,/test/93/waku-multi,/test/94/waku-multi,/test/95/waku-multi,/test/96/waku-multi,/test/97/waku-multi,/test/98/waku-multi,/test/99/waku-multi,/test/100/waku-multi: Error: Filter subscribe request f633c004-a4f1-4941-be15-6d58746a22f8 failed with status code 400: BAD_REQUEST: exceeds maximum content topics: 30 (occurred 1 times)
      at Subscription.handleErrors (file:///home/shared/js-waku/packages/core/src/lib/filter/index.ts:330:13)
      at Subscription.subscribe (file:///home/shared/js-waku/packages/core/src/lib/filter/index.ts:148:10)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Context.<anonymous> (file:///home/shared/js-waku/packages/tests/tests/filter/single_node/subscribe.node.spec.ts:176:9)

  2) Waku Filter V2: Subscribe: Single Service Node
       Error when try to subscribe to more than 101 topics (new limit):
     Error: Error subscribe all peers: Error subscribing to peer: 16Uiu2HAm2pCLy57eotuRiZjWBBEEufkGdQAWdtWFanP6WWvq5Lsk for content topics: /test/1/waku-multi,/test/2/waku-multi,/test/3/waku-multi,/test/4/waku-multi,/test/5/waku-multi,/test/6/waku-multi,/test/7/waku-multi,/test/8/waku-multi,/test/9/waku-multi,/test/10/waku-multi,/test/11/waku-multi,/test/12/waku-multi,/test/13/waku-multi,/test/14/waku-multi,/test/15/waku-multi,/test/16/waku-multi,/test/17/waku-multi,/test/18/waku-multi,/test/19/waku-multi,/test/20/waku-multi,/test/21/waku-multi,/test/22/waku-multi,/test/23/waku-multi,/test/24/waku-multi,/test/25/waku-multi,/test/26/waku-multi,/test/27/waku-multi,/test/28/waku-multi,/test/29/waku-multi,/test/30/waku-multi,/test/31/waku-multi,/test/32/waku-multi,/test/33/waku-multi,/test/34/waku-multi,/test/35/waku-multi,/test/36/waku-multi,/test/37/waku-multi,/test/38/waku-multi,/test/39/waku-multi,/test/40/waku-multi,/test/41/waku-multi,/test/42/waku-multi,/test/43/waku-multi,/test/44/waku-multi,/test/45/waku-multi,/test/46/waku-multi,/test/47/waku-multi,/test/48/waku-multi,/test/49/waku-multi,/test/50/waku-multi,/test/51/waku-multi,/test/52/waku-multi,/test/53/waku-multi,/test/54/waku-multi,/test/55/waku-multi,/test/56/waku-multi,/test/57/waku-multi,/test/58/waku-multi,/test/59/waku-multi,/test/60/waku-multi,/test/61/waku-multi,/test/62/waku-multi,/test/63/waku-multi,/test/64/waku-multi,/test/65/waku-multi,/test/66/waku-multi,/test/67/waku-multi,/test/68/waku-multi,/test/69/waku-multi,/test/70/waku-multi,/test/71/waku-multi,/test/72/waku-multi,/test/73/waku-multi,/test/74/waku-multi,/test/75/waku-multi,/test/76/waku-multi,/test/77/waku-multi,/test/78/waku-multi,/test/79/waku-multi,/test/80/waku-multi,/test/81/waku-multi,/test/82/waku-multi,/test/83/waku-multi,/test/84/waku-multi,/test/85/waku-multi,/test/86/waku-multi,/test/87/waku-multi,/test/88/waku-multi,/test/89/waku-multi,/test/90/waku-multi,/test/91/waku-multi,/test/92/waku-multi,/test/93/waku-multi,/test/94/waku-multi,/test/95/waku-multi,/test/96/waku-multi,/test/97/waku-multi,/test/98/waku-multi,/test/99/waku-multi,/test/100/waku-multi,/test/101/waku-multi: Error: Filter subscribe request 79991ab6-8362-4228-88cc-4d283a979cc0 failed with status code 400: BAD_REQUEST: exceeds maximum content topics: 30 (occurred 1 times)
      at Subscription.handleErrors (file:///home/shared/js-waku/packages/core/src/lib/filter/index.ts:330:13)
      at Subscription.subscribe (file:///home/shared/js-waku/packages/core/src/lib/filter/index.ts:148:10)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Context.<anonymous> (file:///home/shared/js-waku/packages/tests/tests/filter/single_node/subscribe.node.spec.ts:244:13)

  3) Waku Light Push (named sharding): Multiple PubsubTopics
       Push message on custom pubsubTopic:
     TypeError: Cannot read properties of undefined (reading 'toString')
      at Context.<anonymous> (file:///home/shared/js-waku/packages/tests/tests/light-push/single_node/multiple_pubsub.node.spec.ts:299:43)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

  4) Waku Light Push (named sharding): Multiple PubsubTopics
       Subscribe and receive messages on 2 different pubsubtopics:
     TypeError: Cannot read properties of undefined (reading 'toString')
      at Context.<anonymous> (file:///home/shared/js-waku/packages/tests/tests/light-push/single_node/multiple_pubsub.node.spec.ts:315:44)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

  5) Waku Light Push (named sharding): Multiple PubsubTopics
       Light push messages to 2 nwaku nodes each with different pubsubtopics:
     Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/shared/js-waku/packages/tests/tests/light-push/single_node/multiple_pubsub.node.spec.ts)
      at listOnTimeout (node:internal/timers:573:17)
      at processTimers (node:internal/timers:514:7)

@SionoiS SionoiS merged commit 761ce7b into master Jan 30, 2024
8 of 10 checks passed
@SionoiS SionoiS deleted the vendorbump branch January 30, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Tracks releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants