chore: add 150 kB to msg size histogram metric #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 2c98dd4 |
jm-clius
approved these changes
Feb 14, 2024
alrevuelta
approved these changes
Feb 14, 2024
Ivansete-status
approved these changes
Feb 28, 2024
|
@vpavlin anything needed to merge this? Follow-up suggestions can be introduced in a subsequent PR, if necessary. |
vpavlin
force-pushed
the
feat/add-150-msg-size-histo
branch
from
749efff
to
1fbccdb
Compare
vpavlin
force-pushed
the
feat/add-150-msg-size-histo
branch
from
e40519b
to
987a5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the change of default message max size to 140 kB, we are missing some details in the message size histogram
Changes
This PR adds 150 kB bucket, so that we can see number of messages between 100 - 150 kB. I left the rest in there for the case of non-TWN networks