Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update link to DNS discovery tutorial #2496

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Zorlin
Copy link
Contributor

@Zorlin Zorlin commented Mar 4, 2024

Description

The link to the DNS discovery tutorial is currently broken. This commit should fix it

Changes

Removed one of the ".." from the link path.

How to test

Click the links

Copy link

github-actions bot commented Mar 4, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2496

Built from fba5f4f

@Zorlin Zorlin changed the title Update link to DNS discovery tutorial [docs] Update link to DNS discovery tutorial Mar 4, 2024
@Zorlin
Copy link
Contributor Author

Zorlin commented Mar 4, 2024

Fixed the link properly with a new commit. Please squash this if you choose to merge it and give it a better commit title. :)

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Ivansete-status Ivansete-status changed the title [docs] Update link to DNS discovery tutorial docs: Update link to DNS discovery tutorial Mar 4, 2024
@Ivansete-status Ivansete-status merged commit 9ef2ecc into master Mar 4, 2024
9 of 14 checks passed
@Ivansete-status Ivansete-status deleted the Zorlin-fix-dns-disc-link branch March 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants