test(waku-relay): Relay #2101

AlejandroCabeza · 2023-10-03T07:46:49Z

Description

Implement waku filter relay tests for message id generation

Changes

Implement message id tests.
Implement relay tests.
Update import paths to use test_all.

Dependencies

#2096

github-actions · 2023-10-03T07:52:36Z

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2101

Built from f5c995c

tests/waku_relay/test_protocol.nim

vpavlin · 2023-11-01T12:24:14Z

tests/waku_relay/crypto_utils.nim

+import nimcrypto
+
+
+proc cfbEncode*(key: string, iv: string, data: string): seq[byte] =


Why is this called encode if it actually encrypts ? (same for the proc below)

These were sourced (and slightly adapted) from nimcrypto/examples/cfb.nim, where they used the encode and decode keywords in the respective variables. Thus, I assumed those keywords would be understood.

vpavlin · 2023-11-01T12:42:06Z

tests/waku_relay/test_protocol.nim

+      let fromOtherWakuMessage = fakeWakuMessage("fromOther")
+      discard await node.publish(pubsubTopic, fromOtherWakuMessage)
+
+      # Then the message is published only in both nodes


I think the comment has a copy&paste error:)

Indeed 😅 You repeat one thing too many times and you start missing obvious errors

vpavlin · 2023-11-01T12:49:01Z

tests/waku_relay/test_protocol.nim

+
+      # When decrypting the message
+      let 
+        decryptedText = cfbDecode(key, iv, msg1.payload)


Slightly inconsistent - we have encodedText and decryptedText

True, updating :)

tests/waku_relay/test_protocol.nim

vpavlin · 2023-11-01T13:08:18Z

I am mildly confused about this PR - the title say waku-filter but all the tests are testing relay

AlejandroCabeza · 2023-11-01T14:24:45Z

I am mildly confused about this PR - the title say waku-filter but all the tests are testing relay

That was a typo on my side, updating it.

tests/waku_filter_v2/test_all.nim

tests/waku_relay/test_message_id.nim

tests/waku_relay/test_protocol.nim

gabrielmer

Thanks so much, looks great! :)
Left some comments/questions

tests/waku_relay/test_protocol.nim

gabrielmer

LGTM, thank you!

vpavlin

LGTM

Ivansete-status assigned AlejandroCabeza Oct 5, 2023

AlejandroCabeza force-pushed the test-waku-filter-node-e2e branch from 61bd44a to 72a5f1a Compare October 9, 2023 15:05

AlejandroCabeza requested review from Ivansete-status and gabrielmer October 9, 2023 15:25

AlejandroCabeza force-pushed the test-waku-filter-node-e2e branch 3 times, most recently from 9649704 to 2f3e21e Compare October 12, 2023 19:15

AlejandroCabeza force-pushed the test-relay-subscribe branch from a988c44 to adc5a14 Compare October 12, 2023 19:20

AlejandroCabeza commented Oct 13, 2023

View reviewed changes

tests/waku_relay/test_protocol.nim Outdated Show resolved Hide resolved

tests/waku_relay/test_protocol.nim Outdated Show resolved Hide resolved

tests/waku_relay/test_protocol.nim Show resolved Hide resolved

AlejandroCabeza mentioned this pull request Oct 18, 2023

test(relay-filter): cleanup #2138

Merged

3 tasks

AlejandroCabeza changed the title ~~test(waku-filter): Relay message id~~ test(waku-filter): Relay Oct 20, 2023

AlejandroCabeza mentioned this pull request Oct 20, 2023

bug: Can't reconnect relay client after restart #2145

Closed

AlejandroCabeza requested review from vpavlin and removed request for Ivansete-status October 30, 2023 14:40

AlejandroCabeza force-pushed the test-waku-filter-node-e2e branch from 2f3e21e to 8b135c5 Compare October 31, 2023 18:35

AlejandroCabeza force-pushed the test-relay-subscribe branch from f23a112 to 4f79694 Compare October 31, 2023 18:35

AlejandroCabeza commented Oct 31, 2023

View reviewed changes

tests/waku_relay/test_protocol.nim Show resolved Hide resolved

AlejandroCabeza force-pushed the test-relay-subscribe branch from 4f79694 to c79fad7 Compare November 1, 2023 11:46

vpavlin reviewed Nov 1, 2023

View reviewed changes

tests/waku_relay/test_protocol.nim Show resolved Hide resolved

vpavlin reviewed Nov 1, 2023

View reviewed changes

tests/waku_relay/test_protocol.nim Show resolved Hide resolved

vpavlin reviewed Nov 1, 2023

View reviewed changes

tests/waku_relay/test_protocol.nim Show resolved Hide resolved

AlejandroCabeza changed the title ~~test(waku-filter): Relay~~ test(waku-relay): Relay Nov 1, 2023

AlejandroCabeza mentioned this pull request Nov 1, 2023

bug: Stopped filter node can receive messages #2178

Closed

gabrielmer reviewed Nov 1, 2023

View reviewed changes

gabrielmer reviewed Nov 2, 2023

View reviewed changes

gabrielmer self-requested a review November 8, 2023 08:45

gabrielmer approved these changes Nov 8, 2023

View reviewed changes

vpavlin approved these changes Nov 14, 2023

View reviewed changes

AlejandroCabeza force-pushed the test-waku-filter-node-e2e branch from c1586f0 to f2690a5 Compare November 15, 2023 09:21

AlejandroCabeza force-pushed the test-relay-subscribe branch from a6015e3 to 2ea31aa Compare November 15, 2023 09:21

Base automatically changed from test-waku-filter-node-e2e to test-waku-filter-unsubscribe-all November 15, 2023 09:24

Base automatically changed from test-waku-filter-unsubscribe-all to test-waku-filter-unsubscribe November 15, 2023 09:25

Base automatically changed from test-waku-filter-unsubscribe to master November 15, 2023 09:26

AlejandroCabeza added 17 commits November 15, 2023 16:01

Implement unsubscribe all and payload tests.

e127f5b

Clean imports.

4b58ce9

Implement waku node filter Security and Privacy tests.

35e304e

Fix tests according to expected behaviour.

b5933d7

Implement message id tests.

7a1d55c

Update test import paths.

4f8cb03

Move common code to separate modules.

94d050e

Move sample data payloads to a common directory.

ac938e8

Add helper crypto functions for tests.

525c5f6

Protocol tests: Mostly working, fixing/investigating ongoing errors.

70d7512

Cleanup relay tests.

580dd5f

Remove unused helper functions.

a2282c4

Fixed wrong tests.

3a449d9

Remove unneeded comment:

df6714f

Skip failing test.

47dba38

Add fixes to comments.

f648fe2

Update with PR comments.

4be2375

AlejandroCabeza force-pushed the test-relay-subscribe branch from 2ea31aa to 4be2375 Compare November 15, 2023 15:09

AlejandroCabeza marked this pull request as ready for review November 15, 2023 15:11

AlejandroCabeza merged commit f5f4313 into master Nov 15, 2023
6 of 8 checks passed

AlejandroCabeza deleted the test-relay-subscribe branch November 15, 2023 15:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(waku-relay): Relay #2101

test(waku-relay): Relay #2101

AlejandroCabeza commented Oct 3, 2023 •

edited

github-actions bot commented Oct 3, 2023 •

edited

vpavlin Nov 1, 2023

AlejandroCabeza Nov 1, 2023

vpavlin Nov 1, 2023

AlejandroCabeza Nov 1, 2023

vpavlin Nov 1, 2023

AlejandroCabeza Nov 1, 2023

vpavlin commented Nov 1, 2023

AlejandroCabeza commented Nov 1, 2023

gabrielmer left a comment

gabrielmer left a comment

vpavlin left a comment

		import nimcrypto


		proc cfbEncode*(key: string, iv: string, data: string): seq[byte] =

test(waku-relay): Relay #2101

test(waku-relay): Relay #2101

Conversation

AlejandroCabeza commented Oct 3, 2023 • edited

Description

Changes

Dependencies

github-actions bot commented Oct 3, 2023 • edited

vpavlin Nov 1, 2023

Choose a reason for hiding this comment

AlejandroCabeza Nov 1, 2023

Choose a reason for hiding this comment

vpavlin Nov 1, 2023

Choose a reason for hiding this comment

AlejandroCabeza Nov 1, 2023

Choose a reason for hiding this comment

vpavlin Nov 1, 2023

Choose a reason for hiding this comment

AlejandroCabeza Nov 1, 2023

Choose a reason for hiding this comment

vpavlin commented Nov 1, 2023

AlejandroCabeza commented Nov 1, 2023

gabrielmer left a comment

Choose a reason for hiding this comment

gabrielmer left a comment

Choose a reason for hiding this comment

vpavlin left a comment

Choose a reason for hiding this comment

AlejandroCabeza commented Oct 3, 2023 •

edited

github-actions bot commented Oct 3, 2023 •

edited