Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(relay-filter): cleanup #2138

Merged
merged 7 commits into from
Nov 15, 2023
Merged

test(relay-filter): cleanup #2138

merged 7 commits into from
Nov 15, 2023

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Oct 18, 2023 •
edited
Loading

Description

Cleanup relay and filter tests.

Changes

  • Remove legacy relay tests.
  • Remove unused imports.
  • Add missing payload size test for filter.

Dependencies

#2101

@AlejandroCabeza AlejandroCabeza self-assigned this Oct 18, 2023
@AlejandroCabeza AlejandroCabeza changed the title Filter relay cleanup test(relay-filter): cleanup Oct 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2138

Built from 5605087

@AlejandroCabeza AlejandroCabeza force-pushed the filter-relay-cleanup branch 3 times, most recently from a6bfd6e to 5f3fd09 Compare October 20, 2023 16:30
@AlejandroCabeza AlejandroCabeza mentioned this pull request Oct 20, 2023
Open
Ivansete-status
Ivansete-status reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It is looking good as tests are expected to wait less time!
Besides, I've added a couple of questions :D

tests/waku_filter_v2/test_waku_client.nim Show resolved Hide resolved
tests/waku_relay/test_waku_relay.nim Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza requested review from jm-clius and removed request for rymnc and gabrielmer October 30, 2023 14:35
jm-clius
jm-clius approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlejandroCabeza AlejandroCabeza force-pushed the filter-relay-cleanup branch 2 times, most recently from 5a8478d to 0d7d0db Compare November 1, 2023 14:52
Ivansete-status
Ivansete-status approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@Ivansete-status
Copy link
Collaborator

Ivansete-status commented Nov 1, 2023 •
edited
Loading

I'm happy to merge as long as tests pass in ci :)
( ci / js-waku-node tend to fail so we are overlooking them for now )

Base automatically changed from test-relay-subscribe to master November 15, 2023 15:11
@AlejandroCabeza AlejandroCabeza merged commit bd25191 into master Nov 15, 2023
6 of 8 checks passed
@AlejandroCabeza AlejandroCabeza deleted the filter-relay-cleanup branch November 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@jm-clius jm-clius jm-clius approved these changes

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlejandroCabeza @Ivansete-status @jm-clius