test(waku-filter): Waku node filter privacy and security tests #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from cdd80d7 |
3 tasks
AlejandroCabeza
force-pushed
the
test-waku-filter-node-e2e
branch
from
61bd44a
to
72a5f1a
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-unsubscribe-all
branch
from
b4cbe54
to
5982fa7
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-node-e2e
branch
from
72a5f1a
to
37ea254
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-unsubscribe-all
branch
from
5982fa7
to
b327b50
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-node-e2e
branch
from
37ea254
to
9649704
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-unsubscribe-all
branch
from
b327b50
to
00d7934
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-node-e2e
branch
from
9649704
to
2f3e21e
Compare
3 tasks
AlejandroCabeza
requested review from
jm-clius
and removed request for
ABresting and
alrevuelta
jm-clius
approved these changes
Oct 30, 2023
tests/node/test_wakunode_filter.nim
Outdated
| # Given the client refreshes the subscription | ||
| # TODO: CHECK IF THIS IS NECESSARY. | ||
| # AT FIRST GLANCE IT SEEMS TO COLLIDE WITH WAKU_FILTER_CLIENT'S BEHAVIOUR: SHOULD NOT NEED? | ||
| let subscribeResponse2 = await client.filterSubscribe( |
There was a problem hiding this comment.
Is this required for the test to pass? I would expect that it shouldn't be needed as long as:
- the service node didn't restart
- the client starts up again with the same peerId and transport as before
There was a problem hiding this comment.
It is required, yes.
I think so too, even more given the client doesn't do any unsubscribing, apparently. I'll open a ticket.
AlejandroCabeza
force-pushed
the
test-waku-filter-unsubscribe-all
branch
from
00d7934
to
e260ac6
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-node-e2e
branch
from
2f3e21e
to
8b135c5
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-unsubscribe-all
branch
from
e260ac6
to
9b2e0d8
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-node-e2e
branch
from
c1586f0
to
f2690a5
Compare
AlejandroCabeza
merged commit e3c816a
into
test-waku-filter-unsubscribe-all
6 of 8 checks passed
AlejandroCabeza
added a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement privacy and security tests for waku node filter.
Changes
Dependencies
#2095