Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client to use the async/await syntax #20

Closed
pimeys opened this issue Apr 11, 2018 · 2 comments
Closed

Refactor client to use the async/await syntax #20

pimeys opened this issue Apr 11, 2018 · 2 comments
Labels
ergonomics refactoring
Milestone
v0.4

Comments

@pimeys
Copy link
Contributor

pimeys commented Apr 11, 2018

The async/await syntax is landing to stable Rust later on this year. This will finally help us to get rid of the callback hell, but we might need to upgrade futures and tokio and get the pinning feature from Rust to make this refactoring a bit nicer.
@pimeys pimeys added this to the v0.3 milestone Apr 11, 2018
@pimeys
Copy link
Contributor Author

pimeys commented Nov 29, 2018

Here's the branch, works with the special tokio extension. For testing purposes:

https://github.com/pimeys/a2/tree/async_await

@pimeys
Copy link
Contributor Author

pimeys commented Sep 8, 2019

Merged to master.

@pimeys pimeys closed this as completed Sep 8, 2019
eklipse2k8 pushed a commit to eklipse2k8/rust-apns that referenced this issue Mar 5, 2023
Reduce to 5 keywords for Cargo publish (reown-com#20)
c94fa04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ergonomics refactoring
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@pimeys