Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for completing-read (also helm, etc) #2

Closed
walseb opened this issue Aug 10, 2019 · 1 comment
Closed

Add support for completing-read (also helm, etc) #2

walseb opened this issue Aug 10, 2019 · 1 comment

Comments

@walseb
Copy link
Owner

walseb commented Aug 10, 2019

Right now this package only works with ivy. There are two reasons why. One is that completing read always sorts things which makes it really slow when scanning huge directories. There are ways to fix this but I haven't bothered yet. Another small problem is that using seq-filter to filter out irrelevant entries (those who are above the current directory) instead of the :predicate option in ivy is slightly slower (I remembered measuring a 0.1 ms difference on a pretty large folder). I would rather have better compatibility than the last point though but maybe it would be good to use the ivy method instead of completing read if ivy mode is on because of it

@walseb walseb mentioned this issue Aug 10, 2019
7 tasks
@walseb
Copy link
Owner Author

walseb commented Aug 10, 2019

Fixed!

@walseb walseb closed this as completed Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant