Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Fix proxy script to place commands properly with ar. #9

Closed
GoogleCodeExporter opened this issue Apr 13, 2016 · 4 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. use proxy scripts as described in 
http://cloud9.epfl.ch/testing-programs/producing-llvm-binaries

What is the expected output? What do you see instead?

Archiving blah.a ...
... cloud9/src/testing_targets/build//ar.proxy r blah.a foo.o bar.o
ar: no operation specified


Details of the patch :
 Proxy scripts append parameters from original command at the
 end of the command line. However, binutils ar util requires
 the command option to be passed as the second parameter.
 This patch checks for the command parameter and if present
 inserts it as the second option. Limitation: this patch
 only considers plain commands, not commands with options (a 
 proper reg exp should be used).

Original issue reported on code.google.com by nau...@gmail.com on 26 Aug 2012 at 1:15

Attachments:

@GoogleCodeExporter
Copy link
Author

Aurelien, thanks for the patch! This seems to be a problem, indeed.

Original comment by stefan.b...@gmail.com on 30 Aug 2012 at 9:19

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Applied, thanks!

Original comment by stefan.b...@gmail.com on 30 Aug 2012 at 9:33

  • Changed state: Verified

@GoogleCodeExporter
Copy link
Author

Hi Stefan, 
thanks for applying the patch, unfortunately it was a bit too simplistic and 
broke the build system.
Here is a fix, it matches a bit more that what would really be needed, but that 
should be safe...

Original comment by nau...@gmail.com on 31 Aug 2012 at 11:35

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks for the correction. Applied!

Original comment by stefan.b...@gmail.com on 28 Sep 2012 at 8:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant