Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't apply karaoke template from effect mod #66

Closed
kedaitinh12 opened this issue Aug 3, 2020 · 11 comments
Closed

Can't apply karaoke template from effect mod #66

kedaitinh12 opened this issue Aug 3, 2020 · 11 comments

Comments

@kedaitinh12
Copy link

I Can't apply karaoke template from effect mod, but with old ver 3.2.2 i can apply complete with no error
Ex file: https://drive.google.com/file/d/1OAg_3DWXtUpbJG_Xe-AbF8kZ20VHYrGy/view?usp=drivesdk

@wangqr
Copy link
Owner

wangqr commented Aug 13, 2020

The link you provided gives an error saying file not exist. Can you check that (could be the share permission)?

@kedaitinh12
Copy link
Author

The link you provided gives an error saying file not exist. Can you check that (could be the share permission)?

Sr, it's my fault. The link be ok: https://drive.google.com/file/d/1aSSeXEBAwhEoYHEirmHSA0ra0hMa75IH/view?usp=drivesdk

@wangqr
Copy link
Owner

wangqr commented Aug 16, 2020

The error message I see is:

Runtime error in template code: Expected 1 arguments, got 2
Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))

Looks like the same as #35 (comment)

@kedaitinh12
Copy link
Author

The error message I see is:

Runtime error in template code: Expected 1 arguments, got 2
Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))

Looks like the same as #35 (comment)

I see you don't fixed in new releases

@wangqr
Copy link
Owner

wangqr commented Dec 28, 2020

I'd say the issue is in the lua code, not Aegisub. It should be fixed by adding the parentheses in lua code. There is no point fixing this in Aegisub side.

@wangqr wangqr closed this as completed Dec 28, 2020
@kedaitinh12
Copy link
Author

But why i can apply normally with old ver 3.2.2??

@wangqr
Copy link
Owner

wangqr commented Jan 25, 2021

3.2.2 uses an old version of luajit which is compatible with lua 5.1. The change to lua 5.2 compatible mode was made since release r8231 in 2014, long before the last official release r8942. I think fixing lua code is more reasonable and future proof, than downgrading lua just to support this specific issue.

@kedaitinh12
Copy link
Author

Oh

@kedaitinh12
Copy link
Author

I seen this thread use new Lua can apply normally and use new ffms2 without crash when open video with .opus audio. Can you to reply on Kainote and updated your aegisub completelly in the future

@kedaitinh12
Copy link
Author

@kedaitinh12
Copy link
Author

here fix this error
#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants